Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix If-None-Match not using weak comparison #9063

Merged
merged 3 commits into from
Sep 22, 2024
Merged

Fix If-None-Match not using weak comparison #9063

merged 3 commits into from
Sep 22, 2024

Conversation

Dreamsorcerer
Copy link
Member

@Dreamsorcerer Dreamsorcerer commented Sep 8, 2024 •
edited
Loading

Fixes #8462.

@Dreamsorcerer Dreamsorcerer added backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot labels Sep 8, 2024
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Sep 8, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.30%. Comparing base (684b792) to head (13ee9a2).
Report is 69 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #9063   +/-   ##
=======================================
  Coverage   98.30%   98.30%           
=======================================
  Files         107      107           
  Lines       34356    34389   +33     
  Branches     4071     4073    +2     
=======================================
+ Hits        33772    33805   +33     
  Misses        412      412           
  Partials      172      172
Flag Coverage Δ
CI-GHA 98.19% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.85% <100.00%> (+<0.01%) ⬆️
OS-Windows 96.27% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.53% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 97.63% <100.00%> (+<0.01%) ⬆️
Py-3.10.14 97.56% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.79% <100.00%> (+<0.01%) ⬆️
Py-3.12.5 97.91% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 97.52% <100.00%> (+<0.01%) ⬆️
Py-3.9.19 97.46% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 97.07% <100.00%> (+<0.01%) ⬆️
VM-macos 97.53% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.85% <100.00%> (+<0.01%) ⬆️
VM-windows 96.27% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit 3c1ca45 into master Sep 22, 2024
35 of 36 checks passed
@bdraco bdraco deleted the fix-if-none-match branch September 22, 2024 16:24
@patchback Patchback
Copy link
Contributor

patchback bot commented Sep 22, 2024 •
edited
Loading

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/3c1ca45515b766ceb8bbbd8d710096c03106dd38/pr-9063

Backported as #9237

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Sep 22, 2024
@Dreamsorcerer @patchback
Fix If-None-Match not using weak comparison (#9063)
76531fc 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit 3c1ca45)
@patchback Patchback
Copy link
Contributor

patchback bot commented Sep 22, 2024 •
edited
Loading

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/3c1ca45515b766ceb8bbbd8d710096c03106dd38/pr-9063

Backported as #9238

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback patchback bot mentioned this pull request Sep 22, 2024
Merged
patchback bot pushed a commit that referenced this pull request Sep 22, 2024
@Dreamsorcerer @patchback
Fix If-None-Match not using weak comparison (#9063)
e4d821f 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit 3c1ca45)
@patchback patchback bot mentioned this pull request Sep 22, 2024
Merged
bdraco pushed a commit that referenced this pull request Sep 22, 2024
@patchback
[PR #9063/3c1ca455 backport][3.10] Fix If-None-Match not using weak c…
6fbe677 
…omparison (#9237)

Co-authored-by: Sam Bull <[email protected]>
Fixes #8462.
bdraco pushed a commit that referenced this pull request Sep 22, 2024
@patchback
[PR #9063/3c1ca455 backport][3.11] Fix If-None-Match not using weak c…
51870a9 
…omparison (#9238)

Co-authored-by: Sam Bull <[email protected]>
Fixes #8462.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdraco bdraco bdraco approved these changes

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner

Assignees
No one assigned
Labels
backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Weak Etag can not trigger negotiation caching
2 participants
@Dreamsorcerer @bdraco